Implement about screen roughly #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Detekt check failed. Please run |
takahirom
reviewed
Jul 19, 2024
| import io.github.droidkaigi.confsched.designsystem.strings.Strings | ||
| import io.github.droidkaigi.confsched.designsystem.strings.StringsBindings | ||
|
|
||
| sealed class AboutStrings : Strings<AboutStrings>(Bindings) { |
There was a problem hiding this comment.
Thanks. How about adding TODO here like // TODO: Please migrate this to Compose Multiplatform resources instead of this here because we don't use Strings class for this year.
takahirom
reviewed
Jul 19, 2024
| .padding( | ||
| horizontal = 12.dp, | ||
| ), | ||
| tint = Color.Green, |
There was a problem hiding this comment.
How about adding // TODO: Migrate this to theme's color here? 👀
takahirom
reviewed
Jul 19, 2024
| ) | ||
| item { | ||
| AboutFooterLinks( | ||
| versionName = "1.6.0", |
There was a problem hiding this comment.
Could you add // TODO: Inject the right version name?
ta9ho4
force-pushed
the
feature/implement-about
branch
from
45fca8f to
b5dbb0c
Compare
added 3 commits
July 21, 2024 00:24
# Conflicts: # app-android/src/main/java/io/github/droidkaigi/confsched/KaigiApp.kt
ta9ho4
force-pushed
the
feature/implement-about
branch
from
b5dbb0c to
f89dfb3
Compare
ta9ho4
force-pushed
the
feature/implement-about
branch
3 times, most recently
from
9640421 to
df7c74d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
I implemented about screen roughly
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)