Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Unused Method Classes #993

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

natura1ie
Copy link
Contributor

@natura1ie natura1ie commented Sep 7, 2024

Issue

Overview (Required)

  • I deleted unused method classes in 2024.

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Before After

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 7, 2024 11:51 Inactive
Copy link

github-actions bot commented Sep 7, 2024

Snapshot diff report

File name Image
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter categor
y chip click - when
click category App A
rchitecture en - it
should selected cate
gory App Architectur
e en]_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter day chi
p click - when click
conference day 2 -
it should selected d
ay 2]_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter categor
y chip click - when
click category Other
en - it should sele
cted category Other
en]_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter languag
e chip click - when
click language MIXED
- it should selecte
d language MIXED]_co
mpare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter languag
e chip click - when
click language ENGLI
SH - it should selec
ted language ENGLISH
]_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
input search word t
o TextField - it sho
uld show search word
and filtered items]
_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter categor
y chip click - when
click category Jetpa
ck Compose en - it s
hould selected categ
ory Jetpack Compose
en]_compare.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter day chi
p click - when click
conference day 1 -
it should selected d
ay 1]_compare.png
SearchScreenTest[Sea
rchScreen - when dev
ice is tablet - inpu
t search word to Tex
tField - it should s
how search word and
filtered items]_comp
are.png
SearchScreenTest[Sea
rchScreen - when ser
ver is operational -
when filter languag
e chip click - when
click language JAPAN
ESE - it should sele
cted language JAPANE
SE]_compare.png

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 7, 2024 14:35 Inactive
@takahirom
Copy link
Member

We were talking we remove this after the Kaigi. But it doesn't block it. So we can merge this. Thank you for your contribution!

@takahirom takahirom merged commit f73a145 into DroidKaigi:main Sep 8, 2024
6 checks passed
@natura1ie
Copy link
Contributor Author

@takahirom

I think it's too early to delete them now, but it might be a good idea to start working on deleting them next week, when the event is being held.

I'm sorry for missing this comment in #938.
I'm grateful for your thoughtfulness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete method classes that were used last year but not this year.
2 participants