🔧 Revert Fix bottom space from DayTab offsets in Timetable Screen. #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I apologize for including this bug🙇♂️ |
|
Thank you for doing your best. 🙏 |
![TimetableScreenTest[TimetableScreen - when server is down - it should show error message]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/revert_timetable-nested-scroll/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20down%20-%20it%20should%20show%20error%20message%5D_compare.png){kind=link}
![TimetableScreenTest[TimetableScreen - when server is operational - scroll timetable - it should first session is not displayed]_compare.png](https://github.com/DroidKaigi/conference-app-2024/blob/companion_fix/revert_timetable-nested-scroll/./screenshot-diff-reports/feature/sessions/build/outputs/roborazzi/TimetableScreenTest%5BTimetableScreen%20-%20when%20server%20is%20operational%20-%20scroll%20timetable%20-%20it%20should%20first%20session%20is%20not%20displayed%5D_compare.png){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
We have tried to make the necessary corrections, but there is no prospect of being able to make the corrections by the deadline.
Unfortunately, we have no choice but to revert. 😞
@takahirom @kktaro We apologize for not being able to provide you with the ideal revision response. 🙇
Links
Movie (Optional)
before.mp4
after.mp4