Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When returning after performing a favorite operation on SearchScreen, the favorite icon blinks momentarily #609

Open
kosenda opened this issue Aug 18, 2024 · 4 comments

Comments

@kosenda
Copy link
Contributor

kosenda commented Aug 18, 2024

Overview

This is a very minor thing, but as the title says, if you operate a favorite in SearchScreen and then tap the back button or the back operation of the OS, the favorite icon will blink.

Screen_recording_20240818_161103.mp4
@takahirom
Copy link
Member

This might be difficult to resolve. If it requires very unmaintainable code, I think we don't need to fix it. However, you can try to fix it if you want.

@kyanro
Copy link

kyanro commented Sep 3, 2024

🙋

@kyanro
Copy link

kyanro commented Sep 3, 2024

After investigating, it was found that the issue was caused by the state of the last displayed favorites being momentarily reflected when returning to the screen.

It seems the issue can be resolved by ensuring that the latest state of the favorites is reflected in the display upon returning.

I’ve created a Pull Request to address this, but if there’s a better approach, I would appreciate any advice.

@kyanro
Copy link

kyanro commented Sep 11, 2024

I couldn't resolve the issue, so I will give up for now. 😢

#945 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants