Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Prevent the phenomenon that the background of BottomNavigation is shifted. #554

Merged
merged 4 commits into from
Aug 17, 2024
Merged

🔧 Prevent the phenomenon that the background of BottomNavigation is shifted. #554

merged 4 commits into from
Aug 17, 2024

Conversation

Corvus400
Copy link
Contributor

@Corvus400 Corvus400 commented Aug 17, 2024 •
edited
Loading

Issue

Overview (Required)

  • Only ProfileCardScreen had Scaffolds nested within Scaffolds.
  • This bug can be fixed by removing the nesting of Scaffolds.

Movie (Optional)

Before After
before.mp4
after.mp4

@Corvus400
🔧 Fix Scaffold so that it is not nested.
9c8ebc2
@Corvus400
Merge branch 'main' of github.com:Corvus400/conference-app-2024 into …
068354b 
…bugfix/fix_bottom_navigation_background

# Conflicts:
#	feature/profilecard/src/commonMain/kotlin/io/github/droidkaigi/confsched/profilecard/ProfileCardScreen.kt
@Corvus400 Corvus400 changed the title 🔧 Fix Scaffold so that it is not nested. 🔧 Prevent the phenomenon that the background of BottomNavigation is shifted. Aug 17, 2024
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 17, 2024 04:13 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 17, 2024 04:17 Inactive
@github-actions GitHub Actions
Copy link

Snapshot diff report

File name Image
ProfileCardScreenTes
t[ProfileCardScreen
- when profile card
is exists - it shoul
d show card screen]_
compare.png
ProfileCardScreenTes
t[ProfileCardScreen
- when profile card
is exists - flip pri
fle card - it should
back side of the pr
ofile card is displa
yed]_compare.png

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 17, 2024 04:32 Inactive
@Corvus400 Corvus400 marked this pull request as ready for review August 17, 2024 05:06
@Corvus400
Copy link
Contributor Author

@takahirom
The tag is still attached, but the PR status has been changed from Draft to Open. 🫡

@takahirom
Copy link
Member

takahirom commented Aug 17, 2024 •
edited
Loading

May I ask where the cause of the issue with the shifted background of BottomNavigation is? 🙋

takahirom
takahirom approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, this is better than what we have! Thank you for your contribution!

@takahirom takahirom merged commit ae4f887 into DroidKaigi:main Aug 17, 2024
8 checks passed
@Corvus400
Copy link
Contributor Author

@takahirom

May I ask where the cause of the issue with the shifted background of BottomNavigation is? 🙋

Unfortunately, we do not know what is the definite cause. 🙇
All we know are the following facts. 💁‍♂️

  1. only the ProfileCardScreen where the problem was occurring had a structure that nested Scaffolds
  2. the problem occurs when both scrolling and keyboard display occur at the same time
  3. the “layout boundary” was not displayed on the misaligned background
  4. commenting out the Canvas still causes the background to be displayed out of alignment
  5. adjusting the offset to dynamically correct the position of the Canvas as the keyboard is displayed does not solve the problem of the background being displayed in a misaligned position
Screen_recording_20240817_113546.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] The background of BottomNavigation is sometimes displayed out of alignment.
2 participants
@Corvus400 @takahirom