Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translations and migrate Compose Multiplatform resources for CardScreen #408

Open
takahirom opened this issue Aug 14, 2024 · 5 comments
Open

Add translations and migrate Compose Multiplatform resources for CardScreen #408

takahirom opened this issue Aug 14, 2024 · 5 comments
Assignees
@rnitame
Labels
contributions welcome difficulty:medium 🔧 priority:high 🔥 type: design enhancement 🎨

Comments

@takahirom
Copy link
Member

Currently, we are hardcoding the texts
@rnitame
Copy link
Contributor

rnitame commented Aug 14, 2024

🙋‍♀️

@takahirom
Copy link
Member Author

Thanks! Assgined

@rnitame
Copy link
Contributor

rnitame commented Aug 14, 2024 •
edited
Loading

@takahirom Just to confirm, CardScreen == ProfileCardScreen, right?

@takahirom
Copy link
Member Author

You can do it all. But the EditScreen is currently being implemented. Therefore, conflicts may occur.
#112

@mannodermaus
Copy link
Contributor

I can't seem to find any hardcoded references to strings in the profilecard feature anymore. I wonder if we can close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnitame rnitame

Labels
contributions welcome difficulty:medium 🔧 priority:high 🔥 type: design enhancement 🎨
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@takahirom @mannodermaus @rnitame