Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EventMapItemPreview #321

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

kseito
Copy link
Contributor

@kseito kseito commented Aug 12, 2024

Issue

Overview (Required)

  • Add EventMapItemPreview
  • When I checked using Roborazzi, two images were displayed. Is this ok?

Links

Nothing.

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

Movie (Optional)

Nothing.

@kseito kseito marked this pull request as ready for review August 12, 2024 00:50
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 12, 2024 02:59 Inactive
Copy link

Snapshot diff report

File name Image
EventMapItemPreview_
compare.png

Copy link

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@takahirom
Copy link
Member

Sorry I tried to fix the conflict by GitHub UI. But I couldn't. Could you take a look at it?

@kseito
Copy link
Contributor Author

kseito commented Aug 12, 2024

got it. i will try.

@takahirom
Copy link
Member

Thanks!

Copy link

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 12, 2024 07:31 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 12, 2024 07:40 Inactive
@kseito
Copy link
Contributor Author

kseito commented Aug 12, 2024

@takahirom I fixed it.

Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I'm looking forward to your next contribution!

@takahirom takahirom merged commit 484500c into DroidKaigi:main Aug 12, 2024
7 checks passed
@kseito kseito deleted the feature/add-event-map-item-preview branch August 12, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Preview for EventMapItem
2 participants