Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent refreshing BottomNavBar selected item #317

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Prevent refreshing BottomNavBar selected item #317

merged 3 commits into from
Aug 12, 2024

Conversation

ked4ma
Copy link
Contributor

@ked4ma ked4ma commented Aug 11, 2024

Issue

Overview (Required)

  • When come back from sub screen (e.g. Contributor screen on About tab), selected item of bottom nav bar will be refreshed.
  • Enable to keep selected it.

Links

Movie (Optional)

Before After
Screen_recording_20240812_011844.mp4
Screen_recording_20240812_011939.mp4

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 11, 2024 16:33 Inactive
@ked4ma ked4ma changed the title [WIP] Prevent refreshing BottomNavBar selected item Prevent refreshing BottomNavBar selected item Aug 12, 2024
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 12, 2024 06:11 Inactive
@github-actions github-actions bot temporarily deployed to deploygate-distribution August 12, 2024 06:26 Inactive
@takahirom
Copy link
Member

Do you have any points to fix to make this PR ready for review?

@ked4ma
Copy link
Contributor Author

ked4ma commented Aug 12, 2024 •
edited
Loading

@takahirom
sorry. i've forgotten to change status 🙏

@ked4ma ked4ma marked this pull request as ready for review August 12, 2024 07:12
takahirom
takahirom approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for fixing this bug and fix the issue!

@takahirom takahirom merged commit 8573182 into DroidKaigi:main Aug 12, 2024
6 checks passed
@takahirom takahirom mentioned this pull request Aug 12, 2024
Closed
@hiroaki404 hiroaki404 mentioned this pull request Aug 16, 2024
Merged
@ked4ma ked4ma deleted the feature/hold-selected-bottom-nav-item-316 branch August 23, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BottomNavBar selected item is cleared when come back from child screen
2 participants
@ked4ma @takahirom