Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If it's selected AboutScreen again when selecting AboutScreen, it can not transition to its other child screens. #1016

Closed
nyafunta9858 opened this issue Sep 9, 2024 · 8 comments · Fixed by #1018

Comments

@nyafunta9858
Copy link

Overview

If it's selected AboutScreen again when selecting AboutScreen, it can not transition to other child screens.

Details

record-240909122216.mp4
@nyafunta9858 nyafunta9858 changed the title If it's selected AboutScreen again when selecting AboutScreen, it can not transition to other child screens. If it's selected AboutScreen again when selecting AboutScreen, it can not transition to its other child screens. Sep 9, 2024
@takahirom
Copy link
Member

I can't reproduce the issue. Where did you check it?

@takahirom
Copy link
Member

I'm using
API Level 33 emulator
debug build
main(82bcd5c)

@Corvus400
Copy link
Contributor

@takahirom @nyafunta9858
I was able to check it in my own environment.
There may be a problem if you use SharedTransitionLayout.
The problem does not occur on iOS devices that do not use SharedTransitionLayout in the main, but the same problem occurs on iOS devices that have introduced SharedTransitonaLayout.

iOS main OK iOS shared transition layout NG Android main NG
ios.main.OK.mov
ios.implement.shared.transition.NG.mov
android.main.NG.mp4

@nyafunta9858
Copy link
Author

I have checked with the Android 14 Pixel Fold physical device!

@takahirom
Copy link
Member

When scrolling a little it works. I'm not sure at all.

@takahirom
Copy link
Member

image I think we can remove the dropUnlessResumed.

@takahirom
Copy link
Member

@Corvus400 @nyafunta9858
I'm not sure if this is the same issue that I am experiencing. Could you try removing the dropUnlessResumed() and try again?

@Corvus400
Copy link
Contributor

@takahirom @nyafunta9858
At least on Android, it looks like the navigation problem has been solved, as shown in the video attached to the PR above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants