Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the engineer who is the leader of iOS App #439

Open
takahirom opened this issue May 26, 2021 · 5 comments
Open

About the engineer who is the leader of iOS App #439

takahirom opened this issue May 26, 2021 · 5 comments

Comments

@takahirom
Copy link
Member

Kind (Required)

  • Proposal / Discussion

Overview (Required)

  • I needed someone who knew about iOS apps to get them going.
  • When I talked to ito-san (@ry-itto) , who was the leader of the iOS app last year, he agreed to see it again this year.
  • I talked a bit about architecture and heard that the current standard, Composable Architecture, would be good. I would like to ask if there is anything about this as well.
  • Please let me know if you have any problems.

Links

@ry-itto
Copy link
Member

ry-itto commented May 26, 2021

Thank you!
I'll continue this app's iOS leader.

I think to use following libraries and structures.


Architecture

The Composable Architecture

Project Definition

Swift Package Manager Project Definition

Package Manager

Swift Package Manager

Modules (Draft)

  • Feature Module
    • Module for each feature.
    • Please refer to isowords
  • Component
    • Common components
  • Repository( If necessary )
    • Connecting with KMM Repository layer
  • Utility
    • Common logic, extensions
  • etc ( If necessary )

Following is other part.

Tool Management (Such as SwiftLint)

Swift Package Manager or Mint

CI

GitHub Actions

  • Danger
  • Testing

If someone has any question and opinion about this idea, please let me know 👍🏼

I'll open some issues about iOS app from tomorrow 🙏🏼

@ry-itto
Copy link
Member

ry-itto commented Jun 1, 2021

@takahirom

I needed reviewer for my Pull Request, so I want to add reviewer of iOS App.
@ostk0069 already reviewed my Pull Request and contributed.
So I want to add @ostk0069 as collaborator of this repository.

Could you add him as new collaborator? 🙏🏼

@takahirom
Copy link
Member Author

👀

@takahirom
Copy link
Member Author

I invited @ostk0069 👍

@ry-itto
Copy link
Member

ry-itto commented Jun 2, 2021

Thank you! 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants