Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All open bookmarks lost #1240

Open
mindthump opened this issue Jan 10, 2025 · 5 comments
Open

All open bookmarks lost #1240

mindthump opened this issue Jan 10, 2025 · 5 comments

Comments

@mindthump
Copy link

When Firefox updated to 134.0 (1/10/2025) all open bookmarks were lost. The "Other Bookmarks / Simple Tab Groups" is missing all bookmarks from open (non-archived) groups. Archived groups are untouched.

When I try to bring up the Settings next to the "Manage Bookmarks" item in the drop-down menu nothing happens. "Manage Bookmarks comes up with empty groups. The Settings 'gear' doesn't work there either.

To Reproduce
Can't reproduce myself, they are just gone

Expected behavior
Don't lose my bookmarks, ever. Settings window opens when the 'gear' icon is clicked.

Screenshots

Desktop (please complete the following information):

  • macos 15.1.1 (24B91)
  • Firefox 134.0
  • Simple Tab Groups version: can't tell because the settings won't open

Additional context
None.

@mindthump
Copy link
Author

When I restored bookmarks through Firefox from a backup, STG did not update; it still shows Tab Groups as empty.

@hrHVN
Copy link

hrHVN commented Jan 18, 2025

i'll add to this, the tabs in groups are also randomly deleted between reboots and trying to restore from a backup crashes firefox and no change is done to the Tab-groups.

Desktop

  • Zorin OS 17.2
  • FireFox 134.0.1 (64-bit)
  • Simple Tab Groups 5.2

@philg-dev
Copy link

philg-dev commented Jan 18, 2025

I've seen a few of these reports regarding tab loss with STG at the time of Firefox 134 Release, so I've waited a little bit.

I've made a manual backup before updating and when I updated 134.0.1 was already out.
Luckily I've had no issues at all when I updated to 134.0.1 so far with my STG groups (20+ groups with a total of 800+ tabs) and I hope it stays that way.

Maybe it's possible that the people that are affected by this issue have something else in common? Maybe some other conflicting addons somehow?

I use a lot of addons overall, but the only addons that involve some sort of tab management, that I have are STG and Vimium.

Aside from that, if you even suffer from browser crashes when trying to restore from an STG backup file, you might want to consider downgrading your Firefox if your tabs are important enough for you to consider that.

You could also try and debug the addon during the backup file restoration process and see what's going wrong there.
I'm not familiar with STG's code base, but this seems to be a potential contender for a debugging breakpoint:

async function restoreBackup(data, clearAddonDataBeforeRestore = false) {

You can set the breakpoint in the addon-debugger:

  • about:debugging#/runtime/this-firefox
  • for Simple Tab Groups click the "Inspect" button
  • find the stg-background.js on the left
  • find the relevant line of code and set a breakpoint
  • try to restore a STG backup from file and step through the code

Just in case it turns out to be relevant:
FF 134.0.1
STG v5.2
Arch Linux 64-Bit (Kernel: 6.12.9-arch1-1, GNOME 47.3 on X11)

@able2doit
Copy link

Similar issue: all tabs lost following upgrade to Firefox, not captured pre-upgrade, but most earlier tabs saved and can be retrieved.

Pattern emerging: always after a Firefox upgrade. (Why not automatic like the daily saves?)

My setup: Ubuntu 24.04.1 (installed via apt not snap) , FF 134.0.1, STG 5.2.

@able2doit
Copy link

FF 134.0.2 appeared shortly after the earlier comment. I made a manual STG backup as explained in the website, did the FF upgrade, and the STG tabs all vanished as before. I therefore restored them from the backup and all is back to normal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants