Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify recipes for converting other types of experience fluid (add by other mods) to Liquid Experience #161

Open
AlisonHuang777 opened this issue Apr 6, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@AlisonHuang777
Copy link

AlisonHuang777 commented Apr 6, 2024

Describe the your request

AFAIK, these amounts of experience fluids from other mods can be converted to 10mB of Liquid Experience:

  • 250mB x Essence of Knowledge (from CoFH Core, e.g. Thermal Series)
  • 200mB x Essence (from Industrial Foregoing)
  • 200mB x Fluid XP (from Mob Grinding Utils)

Not only do these recipes not unified on their amounts, but you also need to manually add new recipe to the mod for any new types of experience fluids. Base on this, I suggest this:

  • 250mB x #forge:experience -> 10mB x Liquid Experience

for better compatibility.

@AlisonHuang777 AlisonHuang777 added enhancement New feature or request triage labels Apr 6, 2024
@AlisonHuang777
Copy link
Author

Well actually, I'm using NeoForge right now, so I'm actually not sure whether #forge:experience exists in Forge or not.

@RaymondBlaze
Copy link
Contributor

Nope, the converting recipes are intended to be not unified due to the fact that different fluid experience not having the same amount of experience.

While using tags for the unofficial convention 20mB per 1xp fluids is possible, but it will still be an internal mod tag with CEI's namespace, instead of forge or the new multiloader conventional namespace c for 1.21, since there're mods adding their experience fluid to the forge tag while not obeying the 20mB convention.

Note that an internal mod tag really won't make much difference for the integration work since expecting mods to add their fluids to other mods' tags is basically the same as expecting them to add the integration recipe themselves. Actually, most of the effort we made on integration is for investigating other mods' ratio on xp fluid/items.

Anyways, thanks for the advice on using tags in the recipe, we'll be looking into it, since reducing the amount of mixing recipes would technically be a bit of optimization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants