Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update script.js #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update script.js #1

wants to merge 1 commit into from

Conversation

Uldosphere
Copy link

l18n

@MathisHammel
Copy link
Member

Ahahaha 😂

@TomFevrier
Copy link
Contributor

Je suis fan 😂

Lu-Ks
Lu-Ks approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@Lu-Ks Lu-Ks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻 🚀

AoooR42
AoooR42 suggested changes Sep 5, 2023
View reviewed changes
Copy link

@AoooR42 AoooR42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

petites erreurs

script.js
@@ -9,15 +9,15 @@ document.addEventListener("DOMContentLoaded", function () {
const valueToItemMapping = {
0: "aux impôts payés par Starbucks en France",
0.04: "à une impression A4 en couleur",
0.15: "à un pain au chocolat (selon Jean-François Copé)",
0.15: "d'une chocolatine (selon Jean-François Copé)",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mot pas Français

Suggested change
0.15: "d'une chocolatine (selon Jean-François Copé)",
0.15: "à un pain au chocolat (selon Jean-François Copé)",

script.js
0.2: "à une bouteille d'eau minérale",
0.49: "à 1cm² d'appartement à Lyon",
0.6: "à un gros croc dans un Big Mac",
0.76: "au prix de l'électricité pour 365 charges de smartphone",
0.9: "à une cannette de Kronenbourg",
1: "à 1 litre d'essence en 2002",
1.2: "à 1km en taxi",
1.4: "à un pain au chocolat (pas selon Jean-François Copé)",
1.4: "d'une chocolatine (pas selon Jean-François Copé)",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AoooR42 AoooR42 AoooR42 requested changes

@Lu-Ks Lu-Ks Lu-Ks approved these changes

@lchenay lchenay lchenay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Uldosphere @MathisHammel @TomFevrier @lchenay @Lu-Ks @AoooR42