Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gwt-datetimeformat sources jar has a different .gwt.xml than the regular jar #1

Open
niloc132 opened this issue Feb 16, 2023 · 0 comments

Comments

@niloc132
Copy link

The current release of org.dominokit:gwt-datetimeformat's jar has a .gwt.xml file with all of the correct inherits in it. However, the sources jar has a different .gwt.xml file, one which is missing inherits statements.

The copy found in the sources jar is identical to the one in gwt-datetimeformat/src/main/resources - it seems likely that it replaced the generated one. Instead, consider moving the gwt.xml file to gwt-datetimeformat/src/main/module.gwt.xml, and let the gwt maven plugin do the work of emitting the file into both jars.

Technically, this artifact shouldnt be needed by downstream libraries or applications, but I've just seen a project where the -sources jar ended up replacing the regular jar's contents on the classpath of IJ's built-in dev mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant