Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Don't Update DB if Import fails #2

Open
Dominion5254 opened this issue Mar 13, 2024 · 0 comments
Open

[fix] Don't Update DB if Import fails #2

Dominion5254 opened this issue Mar 13, 2024 · 0 comments

Comments

@Dominion5254
Copy link
Owner

Currently data is imported before validating i.e. an error for Disposition Date is before earliest Acquisition Date will still import the erroring lot as well as any other acquisitions/dispositions in the import file.

Data validation should happen before the DB is updated to prevent a bad db state with disposition lots that cannot be disposed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant