Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix phpstan #31988

Merged
merged 6 commits into from
Nov 18, 2024
Merged

fix phpstan #31988

merged 6 commits into from
Nov 18, 2024

Conversation

frederic34
Copy link
Member

No description provided.

@frederic34
Copy link
Member Author

frederic34 commented Nov 18, 2024 •
edited
Loading 

$permissiontoadd = $user->hasRight('accounting', 'chartofaccount');

if (!$permissiontoadd) {
	accessforbidden();
}
// now $permissiontoadd or $user->hasRight('accounting', 'chartofaccount') are always equal to 1

after the if (!$permissiontoadd) { the only value possible is 1

@eldy eldy merged commit 45b07ca into Dolibarr:develop Nov 18, 2024
6 checks passed
@frederic34 frederic34 deleted the optioncss branch November 18, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederic34 @eldy