From 59dc633007a3cd6fc29e657da7331699f01603f5 Mon Sep 17 00:00:00 2001 From: Alexandre SPANGARO Date: Mon, 18 Nov 2024 10:14:38 +0100 Subject: [PATCH] FIX Loan - Undefined variable #31973 & #31974 --- htdocs/loan/document.php | 4 ++-- htdocs/loan/info.php | 4 ++-- htdocs/loan/list.php | 5 +++-- htdocs/loan/note.php | 9 +++++---- htdocs/loan/schedule.php | 6 +++--- 5 files changed, 15 insertions(+), 13 deletions(-) diff --git a/htdocs/loan/document.php b/htdocs/loan/document.php index bc268e29a5010..3886aba9efe94 100644 --- a/htdocs/loan/document.php +++ b/htdocs/loan/document.php @@ -84,7 +84,7 @@ $modulepart = 'loan'; $permissiontoadd = $user->hasRight('loan', 'write'); // Used by the include of actions_addupdatedelete.inc.php and actions_linkedfiles.inc.php - +$morehtmlright = ''; /* * Actions @@ -128,7 +128,7 @@ $morehtmlref .= '
'; $morehtmlref .= ''; $morehtmlref .= ''; - $morehtmlref .= $formproject->select_projects($object->socid, $object->fk_project, 'projectid', $maxlength, 0, 1, 0, 1, 0, 0, '', 1); + $morehtmlref .= $formproject->select_projects($object->socid, $object->fk_project, 'projectid', 16, 0, 1, 0, 1, 0, 0, '', 1); $morehtmlref .= ''; $morehtmlref .= '
'; } else { diff --git a/htdocs/loan/info.php b/htdocs/loan/info.php index 51d414fdb4ea0..78757779f42ba 100644 --- a/htdocs/loan/info.php +++ b/htdocs/loan/info.php @@ -2,7 +2,7 @@ /* Copyright (C) 2014-2024 Alexandre Spangaro * Copyright (C) 2017 Ferran Marcet * Copyright (C) 2024 MDW - * Copyright (C) 2024 Frédéric France + * Copyright (C) 2024 Frédéric France * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -113,7 +113,7 @@ print '
'; -print '
'; +print '
'; dol_print_object_info($object); print '
'; diff --git a/htdocs/loan/list.php b/htdocs/loan/list.php index 1928ba2db43b9..f2fa046923b8d 100644 --- a/htdocs/loan/list.php +++ b/htdocs/loan/list.php @@ -39,10 +39,11 @@ // Load translation files required by the page $langs->loadLangs(array("banks", "bills", "compta", "loan")); -// Get parameters +$search_all = trim(GETPOST('search_all', 'alphanohtml')); + $action = GETPOST('action', 'aZ09') ? GETPOST('action', 'aZ09') : 'view'; // The action 'create'/'add', 'edit'/'update', 'view', ... $massaction = GETPOST('massaction', 'alpha'); // The bulk action (combo box choice into lists) -$show_files = GETPOSTINT('show_files'); // Show files area generated by bulk actions ? +$show_files = GETPOSTINT('show_files'); // Show files area generated by bulk actions? $confirm = GETPOST('confirm', 'alpha'); // Result of a confirmation $cancel = GETPOST('cancel', 'alpha'); // We click on a Cancel button $toselect = GETPOST('toselect', 'array'); // Array of ids of elements selected into a list diff --git a/htdocs/loan/note.php b/htdocs/loan/note.php index 5fa8ce489f35e..221b46a53e5e4 100644 --- a/htdocs/loan/note.php +++ b/htdocs/loan/note.php @@ -64,7 +64,7 @@ /* - * Actions + * Actions */ @@ -78,10 +78,11 @@ /* - * View + * View */ $form = new Form($db); +$formproject = new FormProjets($db); $title = $langs->trans("Loan").' - '.$langs->trans("Notes"); $help_url = 'EN:Module_Loan|FR:Module_Emprunt'; @@ -90,7 +91,7 @@ if ($id > 0) { /* - * Affichage onglets + * Show tabs */ $totalpaid = $object->getSumPayment(); @@ -114,7 +115,7 @@ $morehtmlref .= '
'; $morehtmlref .= ''; $morehtmlref .= ''; - $morehtmlref .= $formproject->select_projects($object->socid, $object->fk_project, 'projectid', $maxlength, 0, 1, 0, 1, 0, 0, '', 1); + $morehtmlref .= $formproject->select_projects($object->socid, $object->fk_project, 'projectid', 16, 0, 1, 0, 1, 0, 0, '', 1); $morehtmlref .= ''; $morehtmlref .= '
'; } else { diff --git a/htdocs/loan/schedule.php b/htdocs/loan/schedule.php index 31aa7dddc9baa..e48ff1fe77380 100644 --- a/htdocs/loan/schedule.php +++ b/htdocs/loan/schedule.php @@ -3,7 +3,7 @@ * Copyright (C) 2018-2024 Alexandre Spangaro * Copyright (C) 2020 Maxime DEMAREST * Copyright (C) 2024 MDW - * Copyright (C) 2024 Frédéric France + * Copyright (C) 2024 Frédéric France * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -159,7 +159,7 @@ $form = new Form($db); $formproject = new FormProjets($db); -$title = $langs->trans("Loan").' - '.$langs->trans("Card"); +$title = $langs->trans("Loan").' - '.$langs->trans("FinancialCommitment"); $help_url = 'EN:Module_Loan|FR:Module_Emprunt'; llxHeader("", $title, $help_url, '', 0, 0, '', '', '', 'mod-loan page-card_schedule'); @@ -185,7 +185,7 @@ $morehtmlref .= '
'; $morehtmlref .= ''; $morehtmlref .= ''; - $morehtmlref .= $formproject->select_projects(-1, $object->fk_project, 'projectid', $maxlength, 0, 1, 0, 1, 0, 0, '', 1); + $morehtmlref .= $formproject->select_projects(-1, $object->fk_project, 'projectid', 16, 0, 1, 0, 1, 0, 0, '', 1); $morehtmlref .= ''; $morehtmlref .= '
'; } else {