Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PhanTypeMismatchPropertyProbablyReal exceptions in baseline #28878

Conversation

mdeweerd
Copy link
Contributor

Remove PhanTypeMismatchPropertyProbablyReal exceptions in baseline

Removing the exceptions as actions were take to remove some.

@mdeweerd
Copy link
Contributor Author

@eldy I removed all the exceptions for PhanTypeMismatchPropertyProbablyReal as you made a fix for at least one of them.
This PR reports the one that is remaining: ignore for the moment or leave the PR open so that you can fix it?

@mdeweerd mdeweerd force-pushed the qual/no_PhanTypeMismatchPropertyProbablyReal_exceptions branch from 77ad7d1 to cb55fb0 Compare March 16, 2024 13:57
@mdeweerd mdeweerd marked this pull request as ready for review March 16, 2024 14:00
@mdeweerd
Copy link
Contributor Author

All fixed, so the notification can be enabled.

@mdeweerd mdeweerd force-pushed the qual/no_PhanTypeMismatchPropertyProbablyReal_exceptions branch 2 times, most recently from 3d8fc66 to cb55fb0 Compare March 16, 2024 15:39
@eldy eldy merged commit b86e479 into Dolibarr:develop Mar 16, 2024
5 of 6 checks passed
@mdeweerd mdeweerd deleted the qual/no_PhanTypeMismatchPropertyProbablyReal_exceptions branch March 16, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants