Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal #28732

Conversation

mdeweerd
Copy link
Contributor

@mdeweerd mdeweerd commented Mar 9, 2024

Qual: Fix Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal

Fix Qual: Fix PhanTypeMismatchArgumentInternalProbablyReal and enable corresponding detextions by phan in default flow.

@mdeweerd mdeweerd force-pushed the fix/PhanTypeMismatchArgumentInternalProbablyReal branch from dd0fd67 to b73cffe Compare March 9, 2024 17:05
# Qual: Enable PhanTypeMismatchArgumentInternalProbablyReal

PhanTypeMismatchArgumentInternalProbablyReal are fixed and reporting can
be enabled.
@mdeweerd mdeweerd force-pushed the fix/PhanTypeMismatchArgumentInternalProbablyReal branch from b73cffe to bb29ca0 Compare March 9, 2024 19:02
…yReal

# Qual: Rewrite/optimize to fix PhanTypeMismatchArgumentInternalProbablyReal

False positive detecting that  is not an int, rewriting to check
impact
@mdeweerd mdeweerd marked this pull request as ready for review March 9, 2024 19:27
@eldy eldy merged commit 6d9e7b8 into Dolibarr:develop Mar 10, 2024
6 checks passed
@mdeweerd mdeweerd deleted the fix/PhanTypeMismatchArgumentInternalProbablyReal branch March 10, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants