[DATA_MODEL] rename commande_fournisseur_dispatch into receptiondet_batch #27528
Conversation
altairis-tof
changed the title
altairis-tof
changed the title
altairis-tof
changed the title
|
next steps will be the renaming of the CommandeFournisseurDispatch class and then the renaming of fk_commande and fk_commandefourndet fields |
|
Does this mean classic dispatch without reception object will get deprecated? |
|
Hello @fappels , i dont think so; the classic dispatch will still work. |
| ALTER TABLE llx_product DROP COLUMN onportal; | ||
| ALTER TABLE llx_product DROP COLUMN onportal; | ||
|
|
||
| RENAME TABLE llx_commande_fournisseur_dispatch_extrafields TO llx_receptiondet_batch_extrafields; |
There was a problem hiding this comment.
Good. Renaming this table will reduce confusion in how and for what this table is used. It is also a big
To rename a table, you must use "ALTER TABLE ... RENAME ..." (se example at top of the file).
also you must update the trigger used for pgslq:
-- VPGSL8.2 CREATE TRIGGER update_customer_modtime BEFORE UPDATE ON llx_receptiondet_batch FOR EACH ROW EXECUTE PROCEDURE update_modified_column_tms();
There was a problem hiding this comment.
hello @eldy it seems that RENAME TABLE is also good (https://dev.mysql.com/doc/refman/8.0/en/rename-table.html and https://popsql.com/learn-sql/mysql/how-to-rename-a-table-in-mysql) but maybe you have a good reason to not use it ?
There was a problem hiding this comment.
trigger updated here if i understood what you said : 933a36c
There was a problem hiding this comment.
i also changed the way to rename table c2345a4
eldy
added
the
PR to fix - See feedback in comments
|
@eldy fixes done and conflicts solved; i am eager to see this one merged and work on the next PR ;-) |
|
@eldy it's ok for you ? |
lmag
added
PR OK to merge
| @@ -159,6 +159,7 @@ CREATE TRIGGER update_customer_modtime BEFORE UPDATE ON llx_propal FOR EACH ROW | |||
| CREATE TRIGGER update_customer_modtime BEFORE UPDATE ON llx_propal_extrafields FOR EACH ROW EXECUTE PROCEDURE update_modified_column_tms(); | |||
| CREATE TRIGGER update_customer_modtime BEFORE UPDATE ON llx_propal_merge_pdf_product FOR EACH ROW EXECUTE PROCEDURE update_modified_column_tms(); | |||
| CREATE TRIGGER update_customer_modtime BEFORE UPDATE ON llx_propaldet_extrafields FOR EACH ROW EXECUTE PROCEDURE update_modified_column_tms(); | |||
| CREATE TRIGGER update_customer_modtime BEFORE UPDATE ON llx_receptiondet_batch FOR EACH ROW EXECUTE PROCEDURE update_modified_column_tms(); | |||
There was a problem hiding this comment.
No needed because duplicate of line 92
There was a problem hiding this comment.
@altairis-tof There is duplicate create PGSql method in function.sql
follow #26021