Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

# Fix & enable PhanPluginPrintfNotPercent #28805

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

mdeweerd
Copy link
Contributor

Fix PhanPluginPrintfNotPercent by setting format length to non 0 value.

Example of Notification message:

'Format string "%0.10F" contains something that is not a percent sign, it will be treated as a format string '%0.10F' with padding of "0" and alignment of '' but no width. Use %% for a literal percent sign, or '%1$.10F' to be less ambiguous' .

Fix PhanPluginPrintfNotPercent by setting format length to non 0 value.

Example of Notification message:

    'Format string "%0.10F" contains something that is not a percent sign, it will be treated as a format string '%0.10F' with padding of "0" and alignment of '' but no width. Use %% for a literal percent sign, or '%1$.10F' to be less ambiguous' .
@mdeweerd mdeweerd marked this pull request as ready for review March 13, 2024 09:52
@eldy
Copy link
Member

eldy commented Mar 13, 2024

OK. test result seems similar.
image

@eldy eldy merged commit acf84f4 into Dolibarr:develop Mar 13, 2024
6 checks passed
@mdeweerd mdeweerd deleted the fix/PhanPluginPrintfNotPercent branch March 13, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants