Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt at fixing #28645 - API bankaccounts/transfer POST missing the cheque_number #28736

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

JonBendtsen
Copy link
Contributor

FIX #28645 - API bankaccounts/transfer POST missing the cheque_number
Attempt at fixing #28645 in which olaxe asked "it will be nice to have also the cheque_number field so it will be easier to compare with the bank statement and also make the reconciliation easily."

@JonBendtsen
Copy link
Contributor Author

line 190 is simply a copy from line 491, which is why it is as it is and doesn't have any {@required false}

@JonBendtsen
Copy link
Contributor Author

build failed in Travis CI Pull Request for what seemed an unrelated reason so I reformatted line 190 to fit the previous lines better

@JonBendtsen JonBendtsen closed this Mar 9, 2024
@JonBendtsen JonBendtsen deleted the cheque_number branch March 9, 2024 22:17
@JonBendtsen JonBendtsen restored the cheque_number branch March 9, 2024 22:17
@JonBendtsen JonBendtsen reopened this Mar 9, 2024
@eldy eldy merged commit 464b124 into Dolibarr:develop Mar 11, 2024
5 of 6 checks passed
@JonBendtsen JonBendtsen deleted the cheque_number branch March 15, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants