Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoices Draft & Open broken. No pagination possible #28634

Closed
mwelters opened this issue Mar 4, 2024 · 6 comments
Closed

Invoices Draft & Open broken. No pagination possible #28634

mwelters opened this issue Mar 4, 2024 · 6 comments
Labels
Bug This is a bug (something does not work as expected)

Comments

@mwelters
Copy link
Contributor

mwelters commented Mar 4, 2024

Bug

Hi,

Invoices (Bills) listing is broken for Drafts and Open Invoices. "connected with Contact" is preselected to current User.
To see invoices you have to reset the filter.
Pagination does not work as expected, Changing Limit to 100 helps, but not all invoices are shown.
Search by Customer or Invoice Number doesnt work anymore

Dolibarr Version

20.0.0-alpha develop from today

Environment PHP

8.1,27

Environment Database

10.5.23-MariaDB-0+deb11u1

Steps to reproduce the behavior and expected behavior

Klick on Invoices

Attached files

No response

@mwelters mwelters added the Bug This is a bug (something does not work as expected) label Mar 4, 2024
@mwelters
Copy link
Contributor Author

mwelters commented Mar 4, 2024

maybe related to #28635

@mwelters
Copy link
Contributor Author

mwelters commented Mar 7, 2024

Things changed a little after the last commits, but it is more or less unusable:

If I click /compta/facture/list.php?leftmenu=customers_bills it shows only canceled and paid invoices:
image

If I press the X "Clear Filters" it shows all types of invoices (leftout Partner in list)
image

But if I want to see the second page of the list it switches back to the behaviour with only showing paid and canceled invoices.
image

Again X "Clear Filter" pressed and tried to search for Postcode 40472 (exists)
image

@fappels
Copy link
Contributor

fappels commented Mar 7, 2024

Best wait for deep testing until #28512 is merged, quite some features are broken in actual V20 alpha.

@mwelters
Copy link
Contributor Author

mwelters commented Mar 8, 2024

Best wait for deep testing until #28512 is merged, quite some features are broken in actual V20 alpha.

Thank you for this hint. Then I'll wait !

@mwelters
Copy link
Contributor Author

mwelters commented Mar 11, 2024

Best wait for deep testing until #28512 is merged, quite some features are broken in actual V20 alpha.

I reverted back to
git checkout aa37b75

this was the commit before the GETPOST -> GETPOSTINT changes
Fix: GETPOST(...,'int') to GETPOSTINT(...) (#28448)

now working and writing invoices is possible again.

@mwelters
Copy link
Contributor Author

mwelters commented Apr 4, 2024

Listing is fixed with one of the last commits

@mwelters mwelters closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug (something does not work as expected)
Projects
None yet
Development

No branches or pull requests

2 participants