FIX_forgeSQLFromUniversalSearchCriteria was unusable

[atm-saamiperdrix]

forgeSQLFromUniversalSearchCriteria was unusable

[eldy]

Can you provide an example of a case that was not working.
Add it as a phpunit test in method testDolForgeCriteriaCallback() and check that after the change, phpunit is ok ?

[carmelchas]

I am using version 18.x and found issues when trying to use "Form::select_thirdparty_list" with ajax select2.

print img_picto('', '').$form->select_company('', 'socid', '((s.client = 1 OR s.client = 2 OR s.client = 3) AND s.status=1)',            'SelectThirdParty', 0, 0, null, 0, 'minwidth175 maxwidth500 widthcentpercentminusxx');


Search produces the following error:
   "Bad syntax of the search string"

I tried updating the filter to "( s.client IN (1,2,3) )" and get the same error.

I see two(2) issues here:
A. The function does not allow for more than one condition.
B. The function is rejecting perfectly functional filters.

[carmelchas]

Additional example from v18

$object->fields['fk_project'] = array('type'=>'integer:Project:projet/class/project.class.php:1:fk_soc='.$thirdparty_soc_id, 'label'=>'Project', 'picto'=>'project', 'enabled'=>'$conf- >project->enabled', 'position'=>52, 'notnull'=>-1, 'visible'=>-1, 'index'=>1, 'css'=>'maxwidth500 widthcentpercentminusxx', 'validate'=>'1',);

Here it is rejecting the filter "fk_soc=123" with the error "Bad syntax of the search string"

[eldy]

The string syntax for filter looks wrong.
((s.client = 1 OR s.client = 2 OR s.client = 3) AND s.status=1)
You should have use the Universal Search Filter syntax (A structured filter string with parenthesis, AND OR and a criteria
(operand1:operator:operand2). So
(((s.client:=:1) OR (s.client:=:2) OR (s.client:=:3)) AND (s.status:=:1))

[hregis]

@eldy maybe add IN in this function ? ;-)

((s.client:IN:1,2,3) AND (s.status:=:1))

[hregis]

@eldy c'est pas déjà pris en charge d'ailleurs ?

((s.client:in:1,2,3) AND (s.status:=:1))

[eldy]

@eldy c'est pas déjà pris en charge d'ailleurs ?

((s.client:in:1,2,3) AND (s.status:=:1))

Je crois que si...
I think so ...

[hregis]

@eldy arrête de parler français on va se faire engueuler ! ;-)

[carmelchas]

Thank you! We will try this.

[carmelchas]

Je m'excuse de ne pas avoir tenté de poser ma question en français. :-(
Merci. Nous allons essayer cette approche.

[hregis]

@carmelchas tu as bien fait de ne pas parler français ! ;-) c'était un joke ! il est préférable de parler anglais... voir américain ! ;-)

[carmelchas]

Lol.

…

On Thu, Mar 14, 2024 at 8:22 PM Regis Houssin ***@***.***> wrote: @carmelchas <https://github.com/carmelchas> tu as bien fait de ne pas parler français ! ;-) c'était un joke ! il est préférable de parler anglais... voir américain ! ;-) — Reply to this email directly, view it on GitHub <#26921 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADMYZ7VOTV4ILJ37GZVZ7DYYJEO5AVCNFSM6AAAAABACWC3DWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYG4ZTEMJRGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>