From dc8546c7f4bbc9a3fcb4ee02c425faac8ef72200 Mon Sep 17 00:00:00 2001
From: MDW <mdeweerd@users.noreply.github.com>
Date: Sun, 10 Mar 2024 22:40:14 +0100
Subject: [PATCH] Remove fixed PhanPluginSuspiciousParamPosition from baseline

---
 dev/tools/phan/baseline.txt | 29 +++--------------------------
 1 file changed, 3 insertions(+), 26 deletions(-)

diff --git a/dev/tools/phan/baseline.txt b/dev/tools/phan/baseline.txt
index 3ccb13ee59980..6109a9abf46ca 100644
--- a/dev/tools/phan/baseline.txt
+++ b/dev/tools/phan/baseline.txt
@@ -9,9 +9,9 @@
  */
 return [
     // # Issue statistics:
-    // PhanPluginSuspiciousParamPosition : 45+ occurrences
     // PhanPluginDuplicateIfStatements : 30+ occurrences
     // PhanParamSignatureMismatch : 25+ occurrences
+    // PhanPluginSuspiciousParamPosition : 15+ occurrences
     // PhanUndeclaredConstant : 15+ occurrences
     // PhanPluginDuplicateExpressionBinaryOp : 10+ occurrences
     // PhanTypeArraySuspiciousNull : 10+ occurrences
@@ -36,7 +36,6 @@ return [
         'htdocs/adherents/stats/geo.php' => ['PhanTypeArraySuspiciousNull'],
         'htdocs/adherents/type.php' => ['PhanPluginDuplicateExpressionBinaryOp'],
         'htdocs/admin/receiptprinter.php' => ['PhanRedefineFunctionInternal'],
-        'htdocs/admin/translation.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/api/class/api_documents.class.php' => ['PhanPluginDuplicateExpressionBinaryOp'],
         'htdocs/barcode/printsheet.php' => ['PhanPluginDuplicateExpressionBinaryOp'],
         'htdocs/bom/bom_list.php' => ['PhanPluginDuplicateIfStatements'],
@@ -44,30 +43,19 @@ return [
         'htdocs/categories/viewcat.php' => ['PhanPluginDuplicateExpressionBinaryOp'],
         'htdocs/collab/index.php' => ['PhanParamTooMany'],
         'htdocs/comm/action/card.php' => ['PhanPluginDuplicateIfStatements'],
-        'htdocs/comm/action/index.php' => ['PhanPluginSuspiciousParamPosition', 'PhanTypeArraySuspiciousNull', 'PhanTypeInvalidUnaryOperandNumeric'],
+        'htdocs/comm/action/index.php' => ['PhanTypeArraySuspiciousNull', 'PhanTypeInvalidUnaryOperandNumeric'],
         'htdocs/comm/action/pertype.php' => ['PhanPluginDuplicateIfStatements'],
         'htdocs/comm/action/peruser.php' => ['PhanPluginDuplicateIfStatements'],
-        'htdocs/comm/mailing/card.php' => ['PhanPluginDuplicateIfStatements', 'PhanPluginSuspiciousParamPosition'],
-        'htdocs/comm/mailing/cibles.php' => ['PhanPluginSuspiciousParamPosition'],
-        'htdocs/comm/mailing/info.php' => ['PhanPluginSuspiciousParamPosition'],
+        'htdocs/comm/mailing/card.php' => ['PhanPluginDuplicateIfStatements'],
         'htdocs/comm/propal/list.php' => ['PhanPluginDuplicateIfStatements'],
         'htdocs/commande/list.php' => ['PhanPluginDuplicateIfStatements'],
         'htdocs/compta/accounting-files.php' => ['PhanTypeInvalidUnaryOperandNumeric'],
-        'htdocs/compta/bank/various_payment/card.php' => ['PhanPluginSuspiciousParamPosition'],
-        'htdocs/compta/bank/various_payment/document.php' => ['PhanPluginSuspiciousParamPosition'],
-        'htdocs/compta/bank/various_payment/info.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/compta/cashcontrol/cashcontrol_card.php' => ['PhanPluginDuplicateExpressionBinaryOp'],
-        'htdocs/compta/facture/agenda-rec.php' => ['PhanPluginSuspiciousParamPosition'],
-        'htdocs/compta/facture/card-rec.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/compta/facture/list.php' => ['PhanPluginDuplicateIfCondition'],
         'htdocs/compta/prelevement/class/bonprelevement.class.php' => ['PhanParamTooMany'],
         'htdocs/compta/prelevement/create.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/compta/sociales/class/paymentsocialcontribution.class.php' => ['PhanTypeInvalidUnaryOperandNumeric'],
-        'htdocs/compta/sociales/document.php' => ['PhanPluginSuspiciousParamPosition'],
-        'htdocs/compta/sociales/info.php' => ['PhanPluginSuspiciousParamPosition'],
-        'htdocs/compta/sociales/note.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/compta/tva/class/paymentvat.class.php' => ['PhanTypeInvalidUnaryOperandNumeric'],
-        'htdocs/compta/tva/document.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/core/actions_massactions.inc.php' => ['PhanPluginDuplicateIfStatements', 'PhanPluginSuspiciousParamOrder'],
         'htdocs/core/class/commondocgenerator.class.php' => ['PhanTypeArraySuspiciousNull'],
         'htdocs/core/class/commonobject.class.php' => ['PhanPluginDuplicateIfCondition', 'PhanPluginDuplicateIfStatements', 'PhanPluginSuspiciousParamPosition'],
@@ -78,7 +66,6 @@ return [
         'htdocs/core/db/mysqli.class.php' => ['PhanParamSignatureMismatch', 'PhanPluginDuplicateIfStatements'],
         'htdocs/core/db/pgsql.class.php' => ['PhanParamSignatureMismatch'],
         'htdocs/core/db/sqlite3.class.php' => ['PhanParamSignatureMismatch'],
-        'htdocs/core/filemanagerdol/connectors/php/connector.lib.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/core/get_info.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/core/lib/files.lib.php' => ['PhanPluginDuplicateExpressionBinaryOp', 'PhanPluginDuplicateIfCondition'],
         'htdocs/core/lib/ftp.lib.php' => ['PhanPluginDuplicateIfStatements'],
@@ -89,7 +76,6 @@ return [
         'htdocs/core/menus/standard/eldy_menu.php' => ['PhanParamSuspiciousOrder', 'PhanPluginDuplicateIfStatements'],
         'htdocs/core/menus/standard/empty.php' => ['PhanParamSuspiciousOrder', 'PhanPluginDuplicateIfStatements'],
         'htdocs/core/modules/barcode/mod_barcode_thirdparty_standard.php' => ['PhanParamSignatureMismatch'],
-        'htdocs/core/modules/import/import_xlsx.modules.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/core/modules/member/doc/pdf_standard.class.php' => ['PhanParamSignatureMismatch'],
         'htdocs/core/modules/movement/doc/pdf_standard.modules.php' => ['PhanPluginDuplicateExpressionBinaryOp'],
         'htdocs/core/modules/mrp/doc/pdf_vinci.modules.php' => ['PhanTypeArraySuspiciousNull'],
@@ -102,18 +88,10 @@ return [
         'htdocs/expensereport/card.php' => ['PhanPluginDuplicateIfStatements'],
         'htdocs/expensereport/class/paymentexpensereport.class.php' => ['PhanTypeInvalidUnaryOperandNumeric'],
         'htdocs/fourn/class/api_supplier_invoices.class.php' => ['PhanPluginSuspiciousParamOrder'],
-        'htdocs/fourn/facture/card-rec.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/intracommreport/list.php' => ['PhanAccessPropertyStaticAsNonStatic'],
-        'htdocs/loan/card.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/loan/class/paymentloan.class.php' => ['PhanTypeInvalidUnaryOperandNumeric'],
-        'htdocs/loan/document.php' => ['PhanPluginSuspiciousParamPosition'],
-        'htdocs/loan/info.php' => ['PhanPluginSuspiciousParamPosition'],
-        'htdocs/loan/note.php' => ['PhanPluginSuspiciousParamPosition'],
-        'htdocs/loan/payment/card.php' => ['PhanPluginSuspiciousParamPosition'],
-        'htdocs/loan/schedule.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/mrp/class/mo.class.php' => ['PhanParamSignatureMismatch'],
         'htdocs/product/admin/product_tools.php' => ['PhanNoopStringLiteral'],
-        'htdocs/product/card.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/product/popuprop.php' => ['PhanPluginDuplicateIfStatements'],
         'htdocs/product/stats/card.php' => ['PhanPluginDuplicateIfStatements'],
         'htdocs/projet/tasks/list.php' => ['PhanTypeArraySuspiciousNull'],
@@ -126,7 +104,6 @@ return [
         'htdocs/takepos/invoice.php' => ['PhanPluginSuspiciousParamPosition'],
         'htdocs/user/class/user.class.php' => ['PhanParamSignatureMismatch'],
         'htdocs/variants/class/ProductCombination.class.php' => ['PhanPluginSuspiciousParamPosition'],
-        'htdocs/webportal/class/html.formwebportal.class.php' => ['PhanPluginSuspiciousParamPosition'],
         'internal' => ['PhanUndeclaredConstant'],
     ],
     // 'directory_suppressions' => ['src/directory_name' => ['PhanIssueName1', 'PhanIssueName2']] can be manually added if needed.