Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefilter == 1 and 2 both yield error: "I don't know what 'Lum' means" #90

Open
JohnstonJ opened this issue Aug 10, 2024 · 0 comments
Open

Comments

@JohnstonJ
Copy link

JohnstonJ commented Aug 10, 2024

Describe the bug
The SMDegrain filter crashes with error:

image

To Reproduce

This simple filter statement seems adequate to trigger it:

SMDegrain(prefilter=1)

Prefilter 2 is also broken in the same way.

Expected behavior

The prefilter should be run and applied as part of image processing.

System:

Additional context

At

(prefilter== 1) ? pref.ex_MinBlur(1,Chr,isInter ? """ex_Median(mode="horizontal" ,Y=Lum,UV=uv)""" : "median",Y=Lum) : \
(prefilter== 2) ? pref.ex_MinBlur(2,Chr,isInter ? """ex_Median(mode="horizontalS",Y=Lum,UV=uv)""" : "median",Y=Lum) : \
I notice that a special string is passed to ex_MinBlur containing the named parameter Y=Lum that is to be passed to ex_Median.

Later on, it is passed to Eval, for evaluation inside the ex_MinBlur function. However, that function does not have any variable named Lum in it, and thus I think that is probably the source of the error.

(rg4v) ? clp.removegrain(rg27y,rg27) : Eval("clp."+blurstr+"")

If I change the ex_Median call to read """ex_Median(mode="horizontal" ,Y=Y,UV=uv)""", then the SMDegrain filter will run successfully, but I am not familiar enough with this filter to know whether the results are as expected or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant