Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test run to use transpiled library and not include styles #41

Conversation

alistairjcbrown
Copy link

This change uses AntD code from lib/ instead of es/, using
transpiled code as Jest will not transpile included code from
node_modules. Styles are also not included. There is no change for
build time, which continues to use the module code and pull styles.

Fixes #10
Fixes #24


  • 100% test coverage
  • Code is formatted with Prettier
  • No ESLint warnings
  • No security vulnerabilities in any NPM packages

This change uses AntD code from `lib/` instead of `es/`, using
transpiled code as Jest will not transpile included code from
`node_modules`. Styles are also not included. There is no change for
built time, which continues to use the module code and pull styles.

Fixes DocSpring#10
Fixes DocSpring#24
@alistairjcbrown
Copy link
Author

Ah, I see there's a PR that already tackled part of this - #31
Feel free to close this off if the direction taken in that PR is preferrable 👍

@alistairjcbrown
Copy link
Author

PR #31 has been merged, so this PR is no longer required

@alistairjcbrown alistairjcbrown deleted the bugfix/support-running-under-jest branch June 24, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

craco test fails Does not work with jest
1 participant