Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda recipe should probably use matplotlib-base #1170

Open
jamesmyatt opened this issue Apr 1, 2021 · 1 comment
Open

conda recipe should probably use matplotlib-base #1170

jamesmyatt opened this issue Apr 1, 2021 · 1 comment
Labels
type: technical debt work to optimize or generalize code

Comments

@jamesmyatt
Copy link

jamesmyatt commented Apr 1, 2021

According to the conda-forge docs, the conda recipe should probably depend on the matplotlib-base package, rather than matplotlib: https://conda-forge.org/docs/maintainer/knowledge_base.html#matplotlib

Is this right? Does yellowbrick require pyqt as well or just matplotlib?

For example: conda-forge/geoplot-feedstock#19

Note that the conda-forge recipe uses matplotlib-base: https://github.com/conda-forge/yellowbrick-feedstock/blob/master/recipe/meta.yaml#L25

@jamesmyatt jamesmyatt changed the title yellowbrick yellowbrick conda recipe should probably use matplotlib-base Apr 1, 2021
@jamesmyatt jamesmyatt changed the title yellowbrick conda recipe should probably use matplotlib-base conda recipe should probably use matplotlib-base Apr 1, 2021
@bbengfort bbengfort added the type: technical debt work to optimize or generalize code label Apr 2, 2021
@bbengfort
Copy link
Member

@jamesmyatt thanks for using Yellowbrick and thanks for the note about the conda recipe. Yellowbrick just requires matplotlib, not pyqt; we can look into it during our next conda release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: technical debt work to optimize or generalize code
Projects
None yet
Development

No branches or pull requests

2 participants