Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands): support bot-wide defaults for install_types/contexts #1261

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

shiftinv
Copy link
Member

Summary

One of the promised #1173 followup PRs.
The default_install_types and default_contexts parameters in the Bot constructor apply to all application commands that don't have their own value set for those fields (through the decorator/parameter, x_command_attrs, or the GuildCommandInteraction annotation).

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@shiftinv shiftinv added the t: enhancement New feature label Dec 25, 2024
@shiftinv shiftinv added this to the disnake v2.10 milestone Dec 25, 2024
@shiftinv shiftinv force-pushed the feature/user-app-defaults branch from df1dfef to 459384d Compare December 25, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: enhancement New feature
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

1 participant