Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPhone X support #11

Open
filom opened this issue Feb 16, 2018 · 4 comments
Open

iPhone X support #11

filom opened this issue Feb 16, 2018 · 4 comments

Comments

@filom
Copy link

filom commented Feb 16, 2018

There are some problem with iPhone X borders. Here some screenshots:

screen shot 2018-02-16 at 11 14 00 pm

screen shot 2018-02-16 at 11 14 51 pm

@jjxtra
Copy link
Collaborator

jjxtra commented Apr 7, 2018

How are you presenting it?

@filom
Copy link
Author

filom commented Apr 7, 2018

Here is my code to present the color picker:

    let drColor = DRColorPickerColor(color: c)

    guard let colorPicker = DRColorPickerViewController.newColorPicker(with: drColor) else { return }
    
    colorPicker.rootViewController.showAlphaSlider = false
    
    colorPicker.rootViewController.importBlock = nil
    
    colorPicker.rootViewController.dismissBlock = { cancel in
        self.dismiss(animated: true, completion: nil)
    }
    
    colorPicker.rootViewController.colorSelectedBlock = { color,vc in
       //
    }
    
    colorPicker.modalPresentationStyle = .formSheet
    
    present(colorPicker, animated: true, completion: nil)

@jjxtra
Copy link
Collaborator

jjxtra commented Apr 7, 2018

Does changing to full screen style help?

@filom
Copy link
Author

filom commented Apr 8, 2018

It does not change, "modalPresentationStyle" has effect on iPad only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants