Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison Tests could be more descriptive #7

Open
trasa opened this issue Apr 5, 2024 · 0 comments
Open

Comparison Tests could be more descriptive #7

trasa opened this issue Apr 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@trasa
Copy link
Contributor

trasa commented Apr 5, 2024

Tests might fail with the following not-so-helpful error message:

Test "Connecting to a game server with POST to connect/ - Connecting succeeds with a valid session": tests failed! Quitting!
Error: expected to be equal, 4200 vs. 4200

Obviously the problem is that one of those is an int, and the other is a string -- but how would someone know that?
So instead, perhaps we should try and determine the type of both values, perhaps if the type is string we should print the result as "4200" to maybe make it more clear?

Alternatively, we could print the types of the values themselves ... that's less clear I think.

@trasa trasa added the enhancement New feature or request label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant