Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings access is doing it wrong #65

Open
deanrad opened this issue May 19, 2015 · 3 comments
Open

Settings access is doing it wrong #65

deanrad opened this issue May 19, 2015 · 3 comments

Comments

@deanrad
Copy link

deanrad commented May 19, 2015

The idea is that each setting has a key, and the correct settings file (or JSON) is passed in at process startup time, so your code would only contain

Meteor.settings.public.meta.title

not

Meteor.settings[Meteor.settings.environment].public.meta.title

It's seldom that production and dev settings ought to be in the same file anyway, since you don't want to check in prod settings to source control anyway.

@ryw
Copy link
Contributor

ryw commented May 20, 2015

@chicagogrooves i agree.
@nickw you agree too? you committed this version...

@nickw
Copy link
Member

nickw commented May 20, 2015

Yeah this was never fully implemented and was still in the experimentation phase. @chicagogrooves feel free to open a PR.

@deanrad
Copy link
Author

deanrad commented May 20, 2015

groovy, thanks! Sorry if that was a bit :trollface:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants