Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename header guards to add c++ support #10

Open
DictumMortuum opened this issue May 30, 2016 · 1 comment
Open

Rename header guards to add c++ support #10

DictumMortuum opened this issue May 30, 2016 · 1 comment

Comments

@DictumMortuum
Copy link
Owner

If you expect your code will ever be used from C++ (which a lot of C code is) then you should not use any identifiers with a double underscore.

#ifndef BITMAP__
    //        ^^   May cause problems in C++

As this is reserved for the implementation in C++. Also the term BITMAP is very generic and you are very likely to clash with other libraries try and make it more unique to your project.

DictumMortuum added a commit that referenced this issue May 31, 2016
@DictumMortuum DictumMortuum reopened this Jun 1, 2016
@DictumMortuum
Copy link
Owner Author

Applies to external sort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant