Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about zocalo triggering #767

Open
DominicOram opened this issue Jan 24, 2025 · 0 comments
Open

Think about zocalo triggering #767

DominicOram opened this issue Jan 24, 2025 · 0 comments

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Jan 24, 2025

Following #766 we should look into how we treat the zocalo callback. Previous to the linked PR we would send two messages:

  1. Provide the zocalo environment and the name of the plan that should be triggering analysis
  2. The plan that that then starts triggers the analysis

Following the PR we now only send message 2 and we instantiate the callback with the information from 1 (given that the environment doesn't change at runtime and the plan name only changes based on which plan you are using) but this was a bit of a hotfix. We should think about whether this is a nice architecture. One alternative is to not send the name of the plan that will be doing the triggering but instead just say that if a plan has the zocalo callback attached and a data collection is registered into ispyb then we trigger zocalo. This removes logic from the plan and makes it cleaner but ties us to the assumption that we would like to send all data collection entries to zocalo.

Acceptance Criteria

  • We have a discussion on the architecture
  • Decisions are recorded
  • Architecture implemented if not too large a change
@DominicOram DominicOram moved this to Candidates for Next Sprint in Hyperion Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Candidates for Next Sprint
Development

No branches or pull requests

1 participant