Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pact broker in a subfolder #60

Open
wideklev opened this issue Feb 2, 2018 · 6 comments
Open

Run pact broker in a subfolder #60

wideklev opened this issue Feb 2, 2018 · 6 comments

Comments

@wideklev
Copy link

wideklev commented Feb 2, 2018

Running pact-broker in our kubernetes environment and works very well and have managed very nicely to deploy it using our own helm template.

The downside is that with our template all our service are deployed in a subfolder.

All links in the pact broker are referenced with the urls starting with / which makes all links broken.

It would more reliable if all links including css and js to be relative instead of coded with / to support both running in an own domain or in an subfolder.

@bethesque
Copy link
Contributor

I can't quite understand your set up from your explanation above. Are you talking about the URL paths, or the file paths? Can you give me some text examples please.

@wideklev
Copy link
Author

wideklev commented Feb 5, 2018

We are deploying the pact-broker in a subfolder:
So our url would be something like: example.com/pact-broker:
In that context the urls are still:

<link href='/css/bootstrap.min.css' rel='stylesheet'>
  <link href='/stylesheets/index.css' rel='stylesheet'>
  <script src='/javascripts/jquery-2.1.1.min.js' type='text/javascript'></script>
  <script src='/javascripts/jquery.tablesorter.min.js' type='text/javascript'></script>
  <script src='/js/bootstrap.min.js' type='text/javascript'></script>
  <nav class='navbase-default navbar-right' role='navigation'>
  <div class='container'>
  <ul>
  <li class='navbar-right'>
  <a href='/hal-browser/browser.html'>

And they should be relative ./ instead of /

Maybe the issue should be in this project instead: https://github.com/pact-foundation/pact_broker

@bethesque
Copy link
Contributor

Yep, it belongs in the pact_broker project. I don't have time to look at it right now, but if you know where to make the changes (and they look quite simple) I'm happy to accept a PR.

@christopher-francisco
Copy link

@wideklev did you figure this out?

@bethesque
Copy link
Contributor

The URLs would need to be modified in more than just the place listed above. I'm not even sure of what would need to be changed for this to work.

@somnath157
Copy link

Did you managed to find solution for it? i am facing same issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants