PROD-276: Send custom events for various events across stackbot to go… #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 13, 2016 14:13
…ogle analytics. Events on which we send data to google analytics: * On clicking the submit button. * On pressing enter to make a search. * On clicking Add more button to show more data in the reports. * On logging out. * On logging in.
…ite-search or omnibox) to GA.
aashil
force-pushed
the
dev-276-google-analytics
branch
from
7db3f04 to
d372ff3
Compare
| @@ -49,6 +49,7 @@ export class SearchComponent { | |||
| doSearch(searchField: any) { | |||
| this.queryService.doQuery(searchField, 'site-search').subscribe( | |||
| data => { | |||
| ga('send', 'event', 'Search', 'source', 'site-search'); | |||
There was a problem hiding this comment.
I would move these to before the the doQuery()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ogle analytics.
Events on which we send data to google analytics: