New workspace inheritance feature breaks sort

[matze]

Using the new workspace inheritance feature breaks the sorting

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: TomlError { message: "TOML parse error at line 3, column 8\n  |\n3 | version.workspace = true\n  |        ^\nUnexpected `.`\nExpected `=`\n" }', /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/cargo-sort-1.0.7/src/sort.rs:113:46

[steviez]

I ran into this as well; however, looking at the line from the panic, it seems the issue might actually be in toml_edit::Document's FromStr trait implementation:

cargo-sort/src/sort.rs

Line 113 in e6a795b

let mut toml = input.parse::<Document>().unwrap();

[steviez]

The toml_edit crate at below link supports these kv pairs of the form key.more = value:
https://github.com/toml-rs/toml
But, this repo has its' own copy of toml_edit code, so the issue is indeed with this repo's copy of toml_edit

[matze]

I wonder why this project vendors toml_edit though …

[steviez]

I wonder why this project vendors toml_edit though …

Good question, can you speak to that @DevinR528 ? Any reason not to rip out the copy and depend on the actively maintained crate ?

Edit; oh wait #29

[janpetschexain]

until this gets fixed you can work around that via

version = { workspace = true }

instead of

version.workspace = true

[DevinR528]

Sorry for the slow response. So toml_edit is vendored because it did not support sorting in a controllable way at that time. As @steviez noticed there is an issue to update it to the new toml_edit crate, which now will be even better since cargo now uses it for the new cargo add command. I just haven't had time to do this but it is defiantly on my TODO list!!

Thanks for the interest and the workaround!

[DevinR528]

Will be resolved with #29

[Jasperav]

@DevinR528 is there any timeline?

[DevinR528]

I, unfortunately, have not had much extra time sorry! I do have a start at moving to a non vendored toml_edit crate #29. I'd say I would for sure have some time over my schools winter break, end of December. Sorry I can't give a better timeline than that.

[jplatte]

I might be able to look into it earlier. Are you're okay having your PR taken over?

[DevinR528]

By all means, that would be great! Any questions I can at least prioritize answering. Thanks!

[jayvdb]

Noting that cargo-make's "format-toml" rule can sort these. It is implemented using https://crates.io/crates/taplo-cli .
It needs a .taplo.toml file containing

[formatting]
reorder_keys = true

See https://taplo.tamasfe.dev/configuration/formatter-options.html for more options.

[Jasperav]

@jayvdb Thanks a bunch for mentioning that lib. I did not knew that exists, I switched over without any hassle :)

[haraldh]

any chance for this to land? 🥺

[Jasperav]

@haraldh why not use taplo?

[haraldh]

@Jasperav right... coincidentally just did that :)

[jplatte]

Fixed by #29, #65. There is a regression though, so I won't release yet.