Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat: implement day headers #28160
Chat: implement day headers #28160
Changes from 20 commits
62b8f1d
6ab35ee
0cc3880
eb676e3
eea7555
d10f65d
1fca9d7
965a841
20d1cb0
1fb98d8
fadbe47
18333f3
ee93033
4dd647f
7207cd5
9702d47
441cda4
22ef938
f46646c
4d6e205
3a9ff44
15e5847
64eaa6b
8c78826
346f365
ea0f08c
fa8feb6
8dea506
a731d23
8553707
626b219
f212e70
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to adjust the color values to support all color schemes. I know that Roman is working on this task. Please extract a separate task to 'check the color of the 'day-header' element in all color schemes.'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we should do immediately in context of this task because it's not related to variables Roman's is working on.
Alex, please review on Storybook that color text is expected for all color schemas in all themes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what color are we expect in different themes. I checked all themes and the text is readable everywhere, is that what u asked to check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are almost complete with the PR: #28171. It's better to wait until it is merged and then adjust colors fo the generic color schemes and fluent.saas if it needs.