Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News with publish_date in future #438

Open
e-aakash opened this issue Aug 15, 2020 · 1 comment
Open

News with publish_date in future #438

e-aakash opened this issue Aug 15, 2020 · 1 comment

Comments

@e-aakash
Copy link
Contributor

Blogs with publish_date in future should not be shown/notified.

A simple fix is to not send news items with future publish_date, but this may still send notifications for those blogs as that is decided in news chore. A better fix would be to ignore new entries in news chore.

@pulsejet
Copy link
Collaborator

You probably also want to ensure that the chore ignores posts with future dates both while creating and updating the post. This way, even if the post (which is uniquely identified by the GUID) changes to a far-future date after being created, it doesn't show up at the top of the news feed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants