Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor / reorganization of molecule display functions #27

Open
janash opened this issue Apr 8, 2023 · 1 comment
Open

Refactor / reorganization of molecule display functions #27

janash opened this issue Apr 8, 2023 · 1 comment

Comments

@janash
Copy link
Member

janash commented Apr 8, 2023

The functions used for displaying molecule images using CDK are currently defined in two places. These should be defined in a module, and imported to the components where they are used rather than being defined twice (showSVG, hideSVG, etc). newSearch, loadMore, etc also seem to fit this.

dynamicGrid is also an example of a component that could be reused. It seems to be very similar between the two pages it is used, with perhaps the only difference being the display of the distance (this could be controlled with a conditional)

@ujamshed
Copy link
Collaborator

ujamshed commented Apr 9, 2023

I think we can incorporate the showSVG and hideSVG functions inside the general graph functional component!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants