Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 605 upgrade python version to 311 #610

Merged
merged 13 commits into from
Nov 28, 2024
Merged

feat: 605 upgrade python version to 311 #610

merged 13 commits into from
Nov 28, 2024

Conversation

Carsopre
Copy link
Collaborator

@Carsopre Carsopre commented Nov 27, 2024 •
edited
Loading

Issue addressed

Solves #605

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

Explain how you addressed the resolution of the related issue, what choices you made and why.

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Added wiki page on How to migrate

@Carsopre Carsopre linked an issue Nov 27, 2024 that may be closed by this pull request
Upgrade Python version to >= 3.11 #605
Closed
@Carsopre Carsopre marked this pull request as ready for review November 28, 2024 10:53
ArdtK
ArdtK approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@ArdtK ArdtK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments/questions

.config/Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated
@@ -14,6 +14,7 @@ COPY ra2ce /ra2ce_src/ra2ce
RUN pip install poetry
RUN poetry config virtualenvs.create false
RUN poetry install --without dev,docs,jupyter
# RUN poetry install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line?

pyproject.toml
Comment on lines 22 to +23
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.10'
'Programming Language :: Python :: 3.11'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both lines?

@Carsopre Carsopre merged commit 1b9f0f5 into master Nov 28, 2024
1 of 2 checks passed
@Carsopre Carsopre deleted the feat/605-upgrade-python-version-to-311 branch November 28, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArdtK ArdtK ArdtK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Python version to >= 3.11
2 participants
@Carsopre @ArdtK