Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceName cannot have spaces #28

Closed
Benajax opened this issue Mar 11, 2020 · 5 comments · Fixed by #35
Closed

ServiceName cannot have spaces #28

Benajax opened this issue Mar 11, 2020 · 5 comments · Fixed by #35

Comments

@Benajax
Copy link

Benajax commented Mar 11, 2020

Hi, the ServiceName doesn't like spaces so instead of a name like "My Demo Service", I have to type it in as "MyDemoService". It will be good for the extension to be able to handle service names with spaces.
@DarkChaos DarkChaos mentioned this issue Jun 22, 2020
Merged
@cpl-dev
Copy link

cpl-dev commented Jun 24, 2020 •
edited
Loading

Agreed with what its said.

[WhenUsingTopshelf]
A good thing would be to use quoted arguments by default, eg:
MyService.exe install -username “DOMAIN\Service Account” -password “Its A Secret” -servicename “Awesome Service” –autostart

@Dejulia489
Copy link
Owner

Agreed! That would make a great feature enhancement. I would happily merge in the pull request and publish the extension.

@cpl-dev
Copy link

cpl-dev commented Jun 25, 2020

Ok, will dig that!

@darylpeeters
Copy link

I agree, this would make a great future enhancement

@Dejulia489 Dejulia489 linked a pull request Jun 30, 2020 that will close this issue
Feature/add arguments to service #35
Merged
@Dejulia489
Copy link
Owner

Fixed with PR #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/add arguments to service DarkChaos/WindowsServiceManager
4 participants
@darylpeeters @Benajax @cpl-dev @Dejulia489