Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolveA/resolveAAAA replaced with resolve4/resolve6? #14

Open
tkurki opened this issue Sep 1, 2019 · 0 comments
Open

resolveA/resolveAAAA replaced with resolve4/resolve6? #14

tkurki opened this issue Sep 1, 2019 · 0 comments

Comments

@tkurki
Copy link

tkurki commented Sep 1, 2019

resolveA and resolveAAAA mentioned in the readme seem to be missing:

$ node 
> require('./')
{ Advertisement: [Function: Advertisement],
  Browser: [Function: Browser],
  ServiceType: [Function: ServiceType],
  tcp: [Function: tcp],
  udp: [Function: udp],
  all: [Function: all],
  validate: 
   { protocol: [Function: protocol],
     serviceName: [Function: serviceName],
     label: [Function: label],
     port: [Function: port],
     txt: [Function: txt] },
  resolve: [Function: resolveAny],
  resolveA: undefined,                    <---------------
  resolveAAAA: undefined,                 <---------------
  resolveSRV: [Function: resolveSRV],
  resolveTXT: [Function: resolveTXT],
  resolveService: [Function: resolveService] }

I assume they are meant to use

dnssd.js/lib/resolve.js

Lines 81 to 91 in 3fd30a7

function resolve4(name, opts) {
return resolveAny(name, 'A', opts).then(function (result) {
return result.answer.address;
});
}
function resolve6(name, opts) {
return resolveAny(name, 'AAAA', opts).then(function (result) {
return result.answer.address;
});
}
like resolveSRV and resolveTXT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant