Docker Compatibility #45
Conversation
|
This should address #44 for the most part. |
| viper.SetTypeByDefaultValue(true) // Allows []string to be parsed from Env Vars | ||
|
|
||
| viper.SetDefault("host", "tinshop.example.com") | ||
| viper.SetDefault("protocol", "http") |
There was a problem hiding this comment.
Is function ComputeDefaultValues, http is assumed if no protocol, so default value is not needed
There was a problem hiding this comment.
I think this is a matter of preference, so I will make my case but accept your decision.
viper needs a default set (could be nil) in order to assign ENV vars to configuration keys.
For the sake of standardization, I believe this could stay here, and the ComputeDefaultValues should test for invalid values and force them to be the default, instead of being the default section “setter”. This way, all the default values are in one place. What are your thoughts?
| @@ -32,6 +32,52 @@ To proper use this software, here is the checklist: | |||
|
|
|||
| Now simply run it and add a shop inside tinfoil with the address setup in `config` (or `http://localIp:3000` if not specified). | |||
|
|
|||
| # 🐋 Docker | |||
There was a problem hiding this comment.
I would add this section after Dev or build from source and maybe add a sentence with link and this end of 🎮 Use to talk about how to use it with docker.
There was a problem hiding this comment.
I moved the section below Dev or build from source but I don't understand the 🎮 Use part.
|
Please see #46 - PR against |
This set of commits enables TinShop to run on Docker without the need of a
config.yamlfile mapping.I am running as a container and without a configuration file. All settings were transported successfully.
According to Viper docs, ENV vars naturally supersede a config file. I mapped all the missing configs on
viper.