Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append [nsw] (or custom) to all titles #43

Open
DblK opened this issue Sep 6, 2023 · 2 comments
Open

Append [nsw] (or custom) to all titles #43

DblK opened this issue Sep 6, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@DblK
Copy link
Owner

DblK commented Sep 6, 2023

If tinshop is used with other shops the list of New Games can be flooded by other.
To be able to filter entries from our shop we should be able to append text in the name of each entries, that way, filtering within tinfoil will be easy without having to disable other shop.

The feature should allow us to:

  • Decide to append or not a string after each entry name
  • Decide to append the string and default to [tinshop]

Those information should be added to the config file. This should be similar to welcomeMessage and noWelcomeMessage even if it's not at the same place in code.

The modification should alter the mergedLibrary.

@DblK DblK added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 6, 2023
@DblK DblK changed the title Append [nsw] to all title Append [nsw] (or custom) to all titles Sep 6, 2023
@Helvio88
Copy link
Contributor

Helvio88 commented Sep 6, 2023

Would you add some info like the other issue on what are some key files? I might try to take on this, too!

@DblK
Copy link
Owner Author

DblK commented Sep 6, 2023

Here are some additional infos:

  • config/config.go to handle the file configuration (look for welcomeMessage or WelcomeMessage for some example)
  • repository/interfaces.go to add Helper on Config interface with the additional getter. (Since interface will be modified, as stated in the readme you should launch a bash script.
  • gamescollection/collection.go function OnConfigUpdate to alter mergedLibrary by modifying entry.Name.

Tell me if you have additional questions after digging in the code ^^

@Helvio88 Helvio88 mentioned this issue Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants