Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting a custom CertificateValidationCallback on database connections #23

Open
1 task done
MarkOtter opened this issue Nov 4, 2024 · 0 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@MarkOtter
Copy link

MarkOtter commented Nov 4, 2024

Is there an existing issue for this?

  • I have searched the existing open and closed issues

Description

I've created a PR for this, but didn't write an issue yet. Not sure how to link the issue to the PR?

Because of company policies we need to support SSL/TLS connections with certificates of which the root CA is not in the certificate store of the OS. Luckily, .NET supports adding custom certificate validation callback methods to connection 'objects', like httpclient and dbconnection.

We'd like to add this option to the dbup-postgress package as well. In the extension methods, I'd suggest adding overloads to supply such method which will be passed to the Postgres Connection instance.

What is the impact?

This change will add functionality which does not break any existing behaviour or APIs.
Though this is a not so common use case, the added value is big for the consumers requiring this.
Our current solution is to copy/past parts of the code of this package and alter it in our codebase, which makes upgrading of the NuGet package brittle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant