fix: change default character delimiter for Variable Substitution #795
Conversation
|
Can you think of a way of making this optional? Like, allowing the user to use one or the other as the delimiter, based on setup. This would not break compatibility. |
There is already a way of changing this via inheritance. My suggestion with this PR is that it is the wrong default, easily breaking a the interaction with a major DBMS |
|
@JakeGinnivan @droyad bump? |
|
Any chance of getting this fix? We do not use Variable Substitution with DbUp but not being able to create a schema with Stored Procedures is a problem. https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-DOLLAR-QUOTING |
| @@ -26,7 +26,7 @@ public VariableSubstitutionSqlParser(string sqlText, string delimiter = "GO", bo | |||
| /// Delimiter character for variables. | |||
| /// Defaults to `$` but can be overridden in derived classes. | |||
| /// </summary> | |||
| protected virtual char VariableDelimiter => '$'; | |||
| protected virtual char VariableDelimiter => '!'; | |||
There was a problem hiding this comment.
Will this have a similar issue parsing SQL that uses a C style != for example SELECT * FROM task WHERE status != 'Done';
There was a problem hiding this comment.
I don't think !=! is a valid SQL statement
|
This is a non-obvious breaking change. I think there is too much code out there that depends on that delimiter. We may consider a PostgreSQL specific solution. |
closes DbUp/dbup-postgresql#22
This is a backwards incompatible change and would require a major version bump, imho.