Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbup-oracle - Error Attempting to Create or Replace Package due custom delimiter/OracleDatabaseWithDefaultDelimiter does not honor newline #1

Open
dagr8anil opened this issue Jul 28, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@dagr8anil
Copy link

dagr8anil commented Jul 28, 2022

Hi everyone,
When using OracleDatabaseWithDefaultDelimiter or OracleDatabase (with char delimiter parameter), it incorrectly splits the SQL statement in my package body. Example attached via linqpad script. I think the best fix would be to make OracleDatabase (with char delimiter parameter) into a string delimiter (and change the inner methods to honor the string delimiter)

Bug
Capture

Potential fix
image

@dagr8anil dagr8anil added the bug Something isn't working label Jul 28, 2022
@dagr8anil
Copy link
Author

i dont mind making the fix myself as a contributor.

@mjauernig
Copy link
Member

mjauernig commented Oct 19, 2023

Can you make a pull request? Thank you in advance.

@droyad droyad transferred this issue from DbUp/DbUp Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants