Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken analytics-node initialization in analytics-plugin-segment #442

Open
shapel opened this issue Jun 5, 2024 · 1 comment
Open

Broken analytics-node initialization in analytics-plugin-segment #442

shapel opened this issue Jun 5, 2024 · 1 comment

Comments

@shapel
Copy link

shapel commented Jun 5, 2024

Hello @DavidWells ,
First of all, thank you for your effort in creating such a library 💪

Looks like analytics-plugin-segment is broken for nodejs as it use wrong initialization for analytics-node
at https://github.com/DavidWells/analytics/blob/master/packages/analytics-plugin-segment/src/node.js#L48

image

By the way analytics-node is deprecated so we could switch to maintained one @segment/analytics-node
https://segment.com/docs/connections/sources/catalog/libraries/server/node/migration/

PS
Feel free to ping me if you would like me to create PR with such changes.

@shapel shapel changed the title Broken analytics-node initialization Broken analytics-node initialization in analytics-plugin-segment Jun 5, 2024
@cbaker6
Copy link

cbaker6 commented Jul 15, 2024

Probably related, but I can confirm that >=2.0.0 of @analytics/segment doesn’t work (not sending any analytics to Segment), but version 1.1.4 does work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants